Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fixed the modal screen fit issue #1859

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kanishk6103
Copy link
Contributor

Description

This PR fixes #1803

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: kanishk6103 <[email protected]>
Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 72a0c20
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66c396ca21d8e80008e36348
😎 Deploy Preview https://deploy-preview-1859--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@leecalcote
Copy link
Member

@amitamrutiya would you like to offer review on this PR?

Copy link
Contributor

@amitamrutiya amitamrutiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the extra comment; otherwise, LGTM.

_sass/catalog.scss Outdated Show resolved Hide resolved
@Ashparshp
Copy link

@kanishk6103, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

Signed-off-by: Kanishk Tiwari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Catalog] Modals on Meshery Catalog are not fitting to the screen
4 participants