Add search (filter) for an specific Integration on Homepage's Integrations section #1837
Conversation
Signed-off-by: shubhusion <[email protected]>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hargunkaur286
requested review from
hargunkaur286 and
vishalvivekm
and removed request for
hargunkaur286
|
@vishalvivekm can you please review this PR ? |
|
@shubhusion Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. The call is scheduled for Monday at 5:30 PM IST. |
|
@Ashparshp, this PR has already been discussed earlier. In the previous PR, I made a mistake while rebasing the branch, which led to merging other commits into that PR. Therefore, I closed the previous PR and created a new one with the necessary specified changes. |
|
@shubhusion Thanks for the words! |
|
@Ashparshp can you review this PR ? Earlier @hargunkaur286 had reviewed it. |
Signed-off-by: shubhusion <[email protected]>
|
@vishalvivekm required changes has been made. |
|
I found several issues while reviewing your PR. I'm not sure if these are only happening on my end. Screencast.from.2024-08-12.09-50-39.webmI am not able to see the cursor icon on the button and can only click certain areas on the buttons below. Other issues are mentioned in the video. Also, the gap between buttons is different from our previous one. I am using Firefox for testing. |
@amitamrutiya i have made no modifications in buttons. My task was to add a search filter above the icons. |
|
I think this PR makes the above mentioned changes. |
@amitamrutiya buttons are working for me. |
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
|
@amitamrutiya all issues you raised have been rectified. Thanks for the review |
|
@vishalvivekm @sudhanshutech please review this pr |
There was a problem hiding this comment.
We can fix those issues as well, as @amitamrutiya pointed out. However, let's address only the ones that have been modified for now. We can proceed with the PR if @shubhusion is not going to work on the fix. @amitamrutiya, you can take up the rest in a separate issue if you'd like.
@shubhusion thoughts?
@Ashparshp The issues pointed out by @amitamrutiya have been rectified in the last two commits. |
|
Thank you @shubhusion. |
|
@hargunkaur286 can you please review this pr ? |
| @@ -1,83 +1,166 @@ | |||
| <style> | |||
There was a problem hiding this comment.
@shubhusion why the existing search bar that is in catalog page is being not reused? Why we have to create new component and styles? Please reuse that
There was a problem hiding this comment.
@shubhusion i didn't heard from you...
There was a problem hiding this comment.
@sudhanshutech I will make the necessary changes, but I'm a bit busy this week. Please give me some time.
There was a problem hiding this comment.
@shubhusion why the existing search bar that is in catalog page is being not reused? Why we have to create new component and styles? Please reuse that
The styles from the existing search bar on the catalog page were duplicated and adapted for the new search bar on the home page. Some modifications were made to ensure it fits well on the home page.
To reuse the same styles, I will need to create a shared .css file that is accessible to both pages.
|
@shubhusion, I'm adding this as an agenda item to the meeting minutes. Please join the evening call and let's take it forward. |
Description
This PR fixes #1798
Notes for Reviewers
Signed commits