Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pattern icon in catalog single page as fallback icon w/signoff #1824

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

krishkumar84
Copy link
Contributor

@krishkumar84 krishkumar84 commented Jul 14, 2024

Description

This PR fixes #1809

Notes for Reviewers
Screenshot 2024-07-14 163303
@Yashsharma1911 kindly review this
in this i change the file path on error of pattern to service mesh pattern

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Jul 14, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

netlify bot commented Jul 14, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 99344d5
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6693b1f9511e3600088807dd
😎 Deploy Preview https://deploy-preview-1824--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishalvivekm
Copy link
Member

@krishkumar84 Thank you for your contribution.
Let's discuss this on Websites's call on Monday. Add this as an agenda item into the meeting minutes, if you would :)

@vishalvivekm vishalvivekm merged commit 4929aab into meshery:master Jul 14, 2024
6 checks passed
Copy link

welcome bot commented Jul 14, 2024

Thanks for your contribution to the Layer5 and Meshery community! 🎉

Meshery Logo
        ⭐ Please leave a star on the project. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pattern icon in catalog single page as fallback icon
2 participants