Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Made video controls visible #1801

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −3
Open

[Fix] Made video controls visible #1801

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c59b954
made help-modal pop-up responsive
Muhammed-Moinuddin Jul 4, 2024
c81c1cb
Merge branch 'meshery:master' into master
Muhammed-Moinuddin Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions _includes/help-modal.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,20 @@
/* Modal Content/Box */
.help-modal-content {
background-color: #fefefe;
margin: 5% auto; /* 5% from the top and centered */
margin: 2% auto; /* 5% from the top and centered */
border: 1px solid #888;
width: 60%; /* Could be more or less, depending on screen size */
@media (max-width: 768px) {
width: 55%; /* Could be more or less, depending on screen size */
@media (max-width: 480px) {
margin: 25% auto;
width: 85%; /* Change width to 85% */
};
@media (min-width: 481px) and (max-width: 768px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use of lot of media queries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it visible in most of the screens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this issue valid with you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this much of use of media quries doesn't sound reasonable. Its hard to maintain . These media quries is always hard to manually maintain. There is other css alternative also

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted

margin: 10% auto;
width: 70%; /* Change width to 85% */
};
@media (min-width: 769px) and (max-width: 1024px) {
margin: 5% auto;
width: 65%; /* Change width to 85% */
}
}

Expand Down
Loading