Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1426] Fix responsiveness issue in Catalog results #1430

Conversation

shiivamtaneja
Copy link
Contributor

@shiivamtaneja shiivamtaneja commented Sep 21, 2023

Description

This PR fixes #1426

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Sep 21, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 7147756
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/650bfd009bd59b00083421cf
😎 Deploy Preview https://deploy-preview-1430--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shiivamtaneja shiivamtaneja force-pushed the shivamtaneja/#1426/responsiveness/catalog-responsive-fixes branch from 5e850b8 to 7147756 Compare September 21, 2023 08:21
Copy link
Member

@Mohith234 Mohith234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @shiivamtaneja, Thanks for your contribution 🚀

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, @shiivamtaneja. 👍

Thanks for this review, @Mohith234 💪

@leecalcote leecalcote merged commit fb85d2d into meshery:master Sep 21, 2023
5 checks passed
@welcome
Copy link

welcome bot commented Sep 21, 2023

Thanks for your contribution to the Layer5 and Meshery community! 🎉

Meshery Logo
        ⭐ Please leave a star on the project. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Responsiveness] Catalog - filtered results arn't within device dimentions
3 participants