Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transparent gap in phone Navbar #1421

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

Akshun-01
Copy link
Contributor

Description
This commit addresses the issue by fixing the transparent gap in the phone Navbar.

This PR fixes #1418

Notes for Reviewers

Before

image

After

image

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Sep 12, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit f21d2bb
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/650591965b0cd00008d4bc97
😎 Deploy Preview https://deploy-preview-1421--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@abhijeetgauravm abhijeetgauravm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Akshun-01 there is inconsistency at some screen size(below ~ 355 px)
image

@Akshun-01
Copy link
Contributor Author

Hi @abhijeetgauravm, there was a minor issue with the width property, I fixed it. Could you please review and tell me if any further changes are needed?

Copy link
Member

@Mohith234 Mohith234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do not include these files Gemfile and Gemfile.lock in your commit

Remove the mentioned files and you are good to go @Akshun-01

@Akshun-01
Copy link
Contributor Author

Hi @Mohith234 , I think I didn't do it the right way. Wasn't I supposed to remove the files and commit and push again ?
Could you help me with this one

@Mohith234
Copy link
Member

  • If you delete it and commit the changes git tracks this as we need to delete the files in the project itself.

  • You can revert the files and then commit the remaining files. It will work fine @Akshun-01

@Akshun-01
Copy link
Contributor Author

Hi @Mohith234 , I reverted the changes in gemfile. You can now review the changes. The navbar is working fine on phone.

@Mohith234
Copy link
Member

@Akshun-01 All good to go, Just squash the commits into one.

@Akshun-01
Copy link
Contributor Author

Akshun-01 commented Sep 17, 2023

Hi @Mohith234 , I squashed the commits. You can review it.
It has some issue with Gemsfile, showing some change but like the same line deleted and added. Is that a bug or some error from my side ?

@Ghat0tkach
Copy link
Member

hey @Akshun-01
Let's discuss it on the websites call.
I have already added your agenda as part of today's meeting minutes

https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

@Akshun-01
Copy link
Contributor Author

Hi @Ghat0tkach, we could not discuss the issue due to time constraints.
Can you review the PR and tell me what I need to do?
I don't think the issue is about code now, it's more about git and github, and I do lack experience with it. So could you please explain it in detail so that I can clear up this issue?

Copy link

@VivekBaldha0712 VivekBaldha0712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@leecalcote leecalcote merged commit 129eba8 into meshery:master Sep 21, 2023
6 checks passed
@welcome
Copy link

welcome bot commented Sep 21, 2023

Thanks for your contribution to the Layer5 and Meshery community! 🎉

Meshery Logo
        ⭐ Please leave a star on the project. 😄

@leecalcote
Copy link
Member

Thank you, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transparent Space Between Navbar items and Logo in Mobile view.
6 participants