-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transparent gap in phone Navbar #1421
Conversation
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. |
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @Akshun-01 there is inconsistency at some screen size(below ~ 355 px)
Hi @abhijeetgauravm, there was a minor issue with the width property, I fixed it. Could you please review and tell me if any further changes are needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Do not include these files
Gemfile
andGemfile.lock
in your commit
Remove the mentioned files and you are good to go @Akshun-01
Hi @Mohith234 , I think I didn't do it the right way. Wasn't I supposed to remove the files and commit and push again ? |
|
Hi @Mohith234 , I reverted the changes in gemfile. You can now review the changes. The navbar is working fine on phone. |
@Akshun-01 All good to go, Just squash the commits into one. |
b2daef1
to
34a0cac
Compare
Signed-off-by: Akshun-01 <[email protected]>
8ed0567
to
f21d2bb
Compare
Hi @Mohith234 , I squashed the commits. You can review it. |
hey @Akshun-01 |
Hi @Ghat0tkach, we could not discuss the issue due to time constraints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
Thanks for your contribution to the Layer5 and Meshery community! 🎉
|
Thank you, all! |
Description
This commit addresses the issue by fixing the transparent gap in the phone Navbar.
This PR fixes #1418
Notes for Reviewers
Before
After
Signed commits