-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove extra whitespace in responsive view #1341
Conversation
Signed-off-by: James Kinyua <[email protected]>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. |
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks, @JayKay24! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks much @JayKay24, container style change won't be necessary here, the real scope of improvement here would be to keep the cards' gap consistent for all device widths alongside updating the section margin/padding consistent between ~700px. Please look into it.
hey @JayKay24 Let's discuss it on the websites call. |
@leecalcote @thisiskaransgit @officialarmannqureshi This problem is no longer in production. This PR could be redundant. |
@JayKay24. the scope of enhacement that I mentioned is still there |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Description
This PR fixes #1238
Notes for Reviewers
Signed commits