Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra whitespace in responsive view #1341

Closed
wants to merge 6 commits into from

Conversation

JayKay24
Copy link
Contributor

@JayKay24 JayKay24 commented Aug 1, 2023

Description

This PR fixes #1238

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Aug 1, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit a23d3cd
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/64cf9a26a012f00008517a2d
😎 Deploy Preview https://deploy-preview-1341--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@leecalcote
Copy link
Member

Thanks, @JayKay24!

Copy link

@officialarmannqureshi officialarmannqureshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @JayKay24! I have thoroughly reviewed all the changes, and I can confirm that they effectively address and eliminate issue #1238 . Great job!

Copy link
Contributor

@thisiskaransgit thisiskaransgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much @JayKay24, container style change won't be necessary here, the real scope of improvement here would be to keep the cards' gap consistent for all device widths alongside updating the section margin/padding consistent between ~700px. Please look into it.

@Ghat0tkach
Copy link
Member

hey @JayKay24

Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)

https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

@JayKay24
Copy link
Contributor Author

JayKay24 commented Aug 6, 2023

@leecalcote @thisiskaransgit @officialarmannqureshi This problem is no longer in production. This PR could be redundant.

@thisiskaransgit
Copy link
Contributor

@JayKay24. the scope of enhacement that I mentioned is still there

@stale
Copy link

stale bot commented Sep 23, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Sep 23, 2023
@stale
Copy link

stale bot commented Sep 30, 2023

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Sep 30, 2023
@vishalvivekm vishalvivekm removed the issue/stale Issue has not had any activity for an extended period of time label Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsiveness issue at /programs
6 participants