Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Updated integrations Section #1311

Merged
merged 2 commits into from
Jul 25, 2023
Merged

[Enhancement] Updated integrations Section #1311

merged 2 commits into from
Jul 25, 2023

Conversation

thisiskaransgit
Copy link
Contributor

@thisiskaransgit thisiskaransgit commented Jul 23, 2023

Description

Changes Done

  • Using .map for iteration over traditional for looping for better loading time.

    The use of .map() allows us to transform each element in the data array into its corresponding HTML card, instead of repeatedly updating innerHTML. This results in better performance, as modifying innerHTML multiple times can be heavy.
Before After
  • Remove hardcoding of integration numbers

    the number displayed currently was hardcoded, even though we had the javascript method declared.

Notes for Reviewers

TODO: Review the Integration Workflow, we are still at ~210 integrations for the meshery.io website. The updated index number should be ~230.

  • We need to reduce the overlapping CSS rules( Website: Consolidate duplicative and unused CSS #896 ), which are largely contributing to the load time
  • Use Kramdown for blogs and posts
  • Utilizing liquid templating more for reusable components, - Code component, - Features sections.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Karan Singh Thakur <[email protected]>
@netlify
Copy link

netlify bot commented Jul 23, 2023

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit bacc9fe
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/64bd6f17f3c14c0008453edb
😎 Deploy Preview https://deploy-preview-1311--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thisiskaransgit thisiskaransgit marked this pull request as ready for review July 23, 2023 18:31
@thisiskaransgit thisiskaransgit changed the title Updated integrations Section [Enhancement] Updated integrations Section Jul 23, 2023
@vishalvivekm
Copy link
Member

@thisiskaransgit Let's discuss this on Websites Meeting call on Monday. Please add this as an agenda item in the meeting mintes if you would. :)

@leecalcote
Copy link
Member

the number displayed currently was hardcoded, even though we had the javascript method declared.

😬

@leecalcote leecalcote merged commit 4a77bdc into meshery:master Jul 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants