-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for dark mode in twitter timeline widget in Footer Element closes #1242 #1256
Added support for dark mode in twitter timeline widget in Footer Element closes #1242 #1256
Conversation
Signed-off-by: ranjanmangla1 <[email protected]>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. |
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@thisiskaransgit @vishalvivekm Even tho meshery has some tweets on it's profile it's displaying "Nothing to see here - yet" 🤔 Also @ranjanmangla1 there's a slight delay while switching to light/dark modes |
|
hey @Savio629, so what changes I have to make in this pr to be merged? |
@ranjanmangla1 Let's discuss this on Websites Meeting call on Monday. Please add this as an agenda item in the meeting mintes if you would. :) |
@samyakshah3008 , hey Samyak, can you review this pr, in past two website meetings this has been an agenda but could not be discussed on both occassions due to lack of time? |
Sure man, let me look into it today. |
@thisiskaransgit, I'm removing |
@ranjanmangla1 Merge conflicts to resolve... |
Signed-off-by: Ranjan Mangla <[email protected]>
Thanks for the PR, but since the widget is not working, due to twitter's new open-access policy, we'll be closing this issue. Thank you for your efforts though. |
Description
This PR fixes #1242
Notes for Reviewers
I have added dark mode functionality for twitter timeline widget for dark mode.
Implementation details:
first, i had tried using changing the data-theme attribute of the tag of twitter widget, it was working but it required reloading the page to see the changes, so it was not feasible at all.
Now, what I have done is for dark mode and light mode, whenever toggle happens, it creates a new widget and then appends to the page, so no refresh is required.
Signed commits
Screenshots:
dark mode
light mode