Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for dark mode in twitter timeline widget in Footer Element closes #1242 #1256

Closed

Conversation

ranjanmangla1
Copy link

@ranjanmangla1 ranjanmangla1 commented Jul 3, 2023

Description

This PR fixes #1242

Notes for Reviewers
I have added dark mode functionality for twitter timeline widget for dark mode.

Implementation details:
first, i had tried using changing the data-theme attribute of the tag of twitter widget, it was working but it required reloading the page to see the changes, so it was not feasible at all.
Now, what I have done is for dark mode and light mode, whenever toggle happens, it creates a new widget and then appends to the page, so no refresh is required.

Signed commits

  • Yes, I signed my commits.

Screenshots:

  • dark mode
    image

  • light mode
    image

@welcome
Copy link

welcome bot commented Jul 3, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@netlify
Copy link

netlify bot commented Jul 3, 2023

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit e4435d2
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/64c55d7cc0f3880008e814af
😎 Deploy Preview https://deploy-preview-1256--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Savio629
Copy link
Contributor

Savio629 commented Jul 3, 2023

@thisiskaransgit @vishalvivekm Even tho meshery has some tweets on it's profile it's displaying "Nothing to see here - yet" 🤔

Also @ranjanmangla1 there's a slight delay while switching to light/dark modes

@ranjanmangla1
Copy link
Author

ranjanmangla1 commented Jul 3, 2023

@thisiskaransgit @vishalvivekm Even tho meshery has some tweets on it's profile it's displaying "Nothing to see here - yet" thinking
nothing to see here yet is happening on meshery.io too, @Savio629

Also @ranjanmangla1 there's a slight delay while switching to light/dark modes
yeah, I know, that is because whenever a toggle happens, a new widget is created and then it is appended to the page. This is the only solution that is working, other wise, the page has to be reloaded to observe the changes. I have added implementation details in the pr description.
Out of the 3 possible solutions, I figured out, this is the only solution that is working well

@ranjanmangla1
Copy link
Author

hey @Savio629, so what changes I have to make in this pr to be merged?

@samyakshah3008
Copy link
Member

@ranjanmangla1 Let's discuss this on Websites Meeting call on Monday. Please add this as an agenda item in the meeting mintes if you would. :)

@ranjanmangla1
Copy link
Author

@samyakshah3008 , hey Samyak, can you review this pr, in past two website meetings this has been an agenda but could not be discussed on both occassions due to lack of time?

@samyakshah3008
Copy link
Member

Sure man, let me look into it today.

@samyakshah3008 samyakshah3008 self-requested a review July 14, 2023 11:07
@thisiskaransgit thisiskaransgit added the pr/on hold PR/Issue on hold label Jul 25, 2023
@Chadha93
Copy link
Member

@thisiskaransgit, I'm removing prhold label, as twittter issue is resolved now

@Chadha93 Chadha93 removed the pr/on hold PR/Issue on hold label Jul 28, 2023
@Chadha93
Copy link
Member

@ranjanmangla1 Merge conflicts to resolve...

Signed-off-by: Ranjan Mangla <[email protected]>
@thisiskaransgit
Copy link
Contributor

Thanks for the PR, but since the widget is not working, due to twitter's new open-access policy, we'll be closing this issue. Thank you for your efforts though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No dark mode for twitter Widget
5 participants