[Site] [Dark Mode] Update import catalog modal according to theme #1203 #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hery#1203 Signed-off-by: Vaibhav Maurya <[email protected]>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
hmm build is failing.. |
|
@vaibhav-xt Let's discuss this on Websites Meeting call on Monday. Please add this as an agenda item in the meeting mintes if you would. :) |
Signed-off-by: Vaibhav Maurya <[email protected]>
vaibhav-xp
force-pushed
the
vaibhav-xt
branch
2 times, most recently
from
d3d831f
to
1260c50
Compare
|
Hello @samyakshah3008, @Chadha93 & @vishalvivekm , please get a review and I think it's ready to merge.
|
Chadha93
suggested changes
Jul 18, 2023
_sass/catalog.scss
Outdated
| @@ -9,6 +9,9 @@ | |||
| font-size: 18px; | |||
| font-weight: 400; | |||
| } | |||
| .tabcontent h3{ | |||
| color: #000; | |||
_sass/catalog.scss
Outdated
| @@ -276,6 +279,11 @@ p { | |||
| text-align: center; | |||
| padding: 15px 0 15px 0; | |||
| } | |||
|
|
|||
| .pattern-name-comingsoon{ | |||
| color: #fff; | |||
|
@vaibhav-xt Review changes pending... |
thisiskaransgit
suggested changes
Jul 25, 2023
There was a problem hiding this comment.
Hey @vaibhav-xt, thank you for your efforts here. The implemented change does not go well with the website.
- The change of text color is desirable, what we need to change is the modal color according to the theme, the same way we implemented it in the catalog modal. This change will be easily done by referencing the color variable.
background-color: var(--integrations-bg);Also, change the tab heading color to Kepple green
- For the coming soon card,
- Remove the declaration of h5 style from
programs.scssand add it to the element style file
h4, h5, h6{
color: var(--color-secondary-dark);
}- Make the style consistent, by removing the background shade.
- Change the overlay-text to be dark mode compatible
The issue that you described was due to the presidency of styles, by following the above steps it will be fixed for this section.
…into vaibhav-xt
Signed-off-by: Vaibhav Maurya <[email protected]>
Chadha93
reviewed
Jul 28, 2023
Signed-off-by: Vaibhav Maurya <[email protected]>
Signed-off-by: Vaibhav Maurya <[email protected]>
thisiskaransgit
approved these changes
Jul 30, 2023
Co-authored-by: Karan Thakur <[email protected]> Signed-off-by: Gaurav Chadha <[email protected]>
Co-authored-by: Karan Thakur <[email protected]> Signed-off-by: Gaurav Chadha <[email protected]>
Chadha93
reviewed
Aug 16, 2023
Chadha93
reviewed
Aug 16, 2023
Signed-off-by: Gaurav Chadha <[email protected]>
Signed-off-by: Gaurav Chadha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is no option left except this. If we declare a sass variable, it conflicts with the dark and light theme colors. @sudhanshutech has tried before this is pr #1114 and it was closed.
This PR fixes #1203
Signed commits