Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pattern icon in catalog single page as fallback icon #1809

Closed
Yashsharma1911 opened this issue Jul 6, 2024 · 5 comments · Fixed by #1824
Closed

Use pattern icon in catalog single page as fallback icon #1809

Yashsharma1911 opened this issue Jul 6, 2024 · 5 comments · Fixed by #1824
Assignees
Labels
framework/jekyll Issues or pull requests that use Jekyll good first issue Good for newcomers kind/bug Something isn't working language/javascript Javascript rela

Comments

@Yashsharma1911
Copy link
Contributor

Description

Currently incase snapshot of designs gets error or not able to render we show service mesh icon it should be replace with pattern icon

Here is a screenshot of the bug

Screenshot 2024-07-06 at 10 05 07 PM

Here is a screenshot of pattern icon with which we want to replace it with, it can be found in existing assets

Screenshot 2024-07-06 at 10 07 38 PM

Expected Behavior

Screenshots

Enviroment:

  • OS: Mac Linux Windows
  • Browser: Chrome Safari Firefox
  • Version:
  • Device: Desktop Mobile

Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

@Yashsharma1911 Yashsharma1911 added kind/bug Something isn't working good first issue Good for newcomers language/javascript Javascript rela framework/jekyll Issues or pull requests that use Jekyll labels Jul 6, 2024
@krishkumar84
Copy link
Contributor

hey kindly assign this to me i want to contribute in this

@Ashparshp
Copy link

@krishkumar84 Go ahead!

@Yashsharma1911
Copy link
Contributor Author

@krishkumar84 checking in! are you still working on this?

@krishkumar84
Copy link
Contributor

@krishkumar84 checking in! are you still working on this?

yes recently i am working on another issue thats why now i am working on this

@Ashparshp
Copy link

Thanks for the update, @krishkumar84!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework/jekyll Issues or pull requests that use Jekyll good first issue Good for newcomers kind/bug Something isn't working language/javascript Javascript rela
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants