Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] [Dark Mode] Update import catalog modal according to theme #1203

Closed
Chadha93 opened this issue Jun 19, 2023 · 10 comments · Fixed by #1247
Closed

[Site] [Dark Mode] Update import catalog modal according to theme #1203

Chadha93 opened this issue Jun 19, 2023 · 10 comments · Fixed by #1247
Assignees
Labels

Comments

@Chadha93
Copy link
Member

Current State of the Meshery.io site

Dark mode issues with modals:
The text is not visible in dark mode.

  1. Import catalog item modal.
    image

Desired State of the Meshery.io site

Update modal text and icons according to dark mode.


Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

@vaibhav-xp
Copy link
Contributor

@Chadha93
Hey, I want to work on this issue. Please assign it to me.

@rush33
Copy link

rush33 commented Jun 20, 2023

@Chadha93 I kindly request permission to resolve this issue. Thanks!

@Chadha93
Copy link
Member Author

Thanks for volunteering, guys! Assigning in chronological order...

@Savio629
Copy link
Contributor

@Chadha93 Can you look at this closed issue? #1169
Sudhanshu was already working on it but his pr was closed and after that I guess @thisiskaransgit misunderstood the issue with the some other pr...

@thisiskaransgit
Copy link
Contributor

@vaibhav-xt, what's your progress?

@vaibhav-xp
Copy link
Contributor

@thisiskaransgit
Since I was not active for 3-4 days. I'll be make pr tomorrow.

@Savio629
Copy link
Contributor

Savio629 commented Jul 3, 2023

@vaibhav-xt There's also an issue present on catalog light theme
The coming soon text is not visible properly....
catalog-light

@vaibhav-xp
Copy link
Contributor

@Savio629 I'll do it. Nice Catch!😎

@stale
Copy link

stale bot commented Aug 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Aug 2, 2023
@Savio629 Savio629 removed the issue/stale Issue has not had any activity for an extended period of time label Aug 3, 2023
@vaibhav-xp
Copy link
Contributor

@Chadha93 please have a look now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants