Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meshsync config on Meshery Operator CRD #533
Meshsync config on Meshery Operator CRD #533
Changes from 13 commits
546a468
0de50cf
80601d3
5fb4c0c
89d4336
0d044ed
23c8bb8
74223bf
06b04a4
0ee99ea
82b973f
6c8f7bd
3127a88
4b42d37
c22a176
daf62b0
ae16176
62887e6
755f03b
b6ca361
9da02fb
71bea27
51d419a
48e251b
388ae67
ea4c118
3cf9449
a9ca7f1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to add a new field to track the configuration of Meshsync. It should show in the
MeshSyncStatus
. We can set the configuration, but we cannot check it by checking the MeshSync status. It is not we what we want to.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the tests cases
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.