Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #524

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Update README.md #524

merged 1 commit into from
Sep 27, 2023

Conversation

rohan472000
Copy link
Contributor

@rohan472000 rohan472000 commented Sep 23, 2023

Description

Made Fill-in bolder in readme of this repo.

This PR fixes #523

Signed-off : Rohan Anand [email protected]

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Rohan Anand <[email protected]>
@welcome
Copy link

welcome bot commented Sep 23, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@rohan472000
Copy link
Contributor Author

@sandramsc review it.

@sandramsc
Copy link
Member

sandramsc commented Sep 23, 2023

@sandramsc review it.

CC: @Mohith234 @Chadha93 @Modern-artist

Hi @rohan472000, maintainers are the ones who generally review, merge PR's here, not necessarily the person who creates the issue.

Also PR's are made once an issue is assigned to you, the issue referenced here hasn't been assigned yet.

If you haven't already, consider reading the newcomers guide here, particularly the section on "Finding an Issue to Work On".

@rohan472000
Copy link
Contributor Author

rohan472000 commented Sep 23, 2023

Thanks for the clarification.

As this issue was really minute, had nothing to discuss over it much, so I raised the PR. Now I've seen the guidelines thoruoghly of this repo, so next time I'll get issue assigned first & then raise PR.

Copy link
Member

@Mohith234 Mohith234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your enthusiasm @rohan472000 , Please do not create any PRs unless the issue is assigned to you. Read the contributing guidelines beforehand.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you, @rohan472000 👍

@leecalcote
Copy link
Member

Ready for your next issue, @rohan472000?

@leecalcote leecalcote merged commit e7568c7 into meshery:master Sep 27, 2023
1 check passed
@welcome
Copy link

welcome bot commented Sep 27, 2023

        Thank you for contributing to the Layer5 community! 🎉 \ \ Meshery Logo \ \         ⭐ Please leave a star on the project. 😄

@rohan472000
Copy link
Contributor Author

Ready for your next issue, @rohan472000?

Yeah sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[README.md] bold styling not applied to text
4 participants