-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meshery broker description #514
Conversation
Signed-off-by: Norbert Oliver <[email protected]>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 50.22% 50.22%
=======================================
Files 9 9
Lines 450 450
=======================================
Hits 226 226
Misses 209 209
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
# Meshery Broker | ||
Meshery Broker is a custom Kubernetes controller that provides data streaming across independent components of Meshery whether those components are running inside or outside of the Kubernetes cluster. | ||
<br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pewpewnor Thanks for this, will you also add a link reference to this slide (45, 46, and 47 talks about broker) for Meshery Broker? https://docs.google.com/presentation/d/1SQMfyu5shjpGKlYONdVzOtd7UYTgLWBcgUvHMLCZ2tY/edit#slide=id.g10af036b3dd_0_0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do, I'll just convert the "meshery broker" to reference the link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it has been done in this commit
Thanks for this @pewpewnor , Please do the changes as suggested by @Chadha93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved cc @leecalcote
Signed-off-by: Norbert Oliver <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for contributing to the Layer5 community! 🎉 \ \ |
@pewpewnor Thank you. |
Description
This PR adds meshery broker description from https://docs.meshery.io/concepts/architecture/broker to resolve issue #509
Notes for Reviewers
Please let me know if the description needs to be edited or anything else. Thank you.
Signed commits