Updated the go version in github actions to 1.20 #167
Conversation
|
@leecalcote Could you please review my pull request when you have a moment? Thank you! |
You bet. Although, I'll likely slow you down. Others that are faster and more knowledgeable than me: @nebula-aac @Revolyssup @abdullah1308 @hexxdump @Aisuko |
|
The runner is not able to find the analysis tools causing the jobs to fail, any idea why this is happening? |
There was a problem hiding this comment.
@leecalcote Thank you.
Hi @VaibhavMalik4187, thanks for your contribution. Currently, we use 'golangci-lint' to check the code quality since we have upgraded to the version of Go. Please help us upgrade the CI to the latest like below. I believe these issues CI cannot find tools should go away.
Aisuko
added
kind/enhancement
Thanks for the pointer @Aisuko. I'll make the necessary changes and update the PR soon. |
VaibhavMalik4187
force-pushed
the
go-version-update
branch
5 times, most recently
from
e509a5a
to
4f5f84d
Compare
|
@Aisuko could you please trigger the tests if you have some spare time? Thanks a lot. |
|
Checks triggered |
VaibhavMalik4187
force-pushed
the
go-version-update
branch
3 times, most recently
from
75d2acf
to
429b404
Compare
@leecalcote I looked into checks run and have also fixed all the errors related to the CI workflow. I had to move to go version 1.21 to get the changes working. Is this acceptable? This PR is now ready for a deeper code review. Thanks! |
VaibhavMalik4187
changed the title
VaibhavMalik4187
force-pushed
the
go-version-update
branch
6 times, most recently
from
cf7368f
to
209d12c
Compare
VaibhavMalik4187
changed the title
|
@nebula-aac, would you mind reviewing the code when you have a moment? Your feedback would be much appreciated. Thanks |
|
I'd also like to highlight that upgrading the linters and error checkers has reported the use of deprecated packages in some parts of the code. I'll be happy to eliminate those errors as a separate issue. |
|
@Aisuko please let me know if any changes are needed. Thanks! |
VaibhavMalik4187
force-pushed
the
go-version-update
branch
3 times, most recently
from
b13d212
to
3095583
Compare
|
@VaibhavMalik4187 Please fix the failing lint tests. |
Switched to explicit declaration of the GO_VERSION variable in the actions files. Earlier the GO_VERSION was being read from the repository secrets. This also involves updating the following jobs to work with the new changes: - Check & Review code - Error check - Static check - Build check Fixes: meshery#147 Signed-off-by: VaibhavMalik4187 <[email protected]>
VaibhavMalik4187
force-pushed
the
go-version-update
branch
from
3095583
to
fd773c1
Compare
|
@Revolyssup I've fixed the failing lint tests. |
Switched to explicit declaration of the GO_VERSION variable in the actions files. Earlier the GO_VERSION was being read from the repository secrets.
Fixes: #147
Signed commits