Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updates go and github actions version #622

Merged
merged 4 commits into from
Jan 15, 2024
Merged

chore: updates go and github actions version #622

merged 4 commits into from
Jan 15, 2024

Conversation

aeswibon
Copy link
Contributor

Description

This PR fixes #621

Notes for Reviewers

  • Updates Go version to 1.21 from 1.19
  • Updates Github Actions to newer version

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Sep 13, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@aeswibon aeswibon marked this pull request as ready for review September 13, 2023 21:02
theBeginner86
theBeginner86 reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@theBeginner86 theBeginner86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Would you please resolve the merge conflicts?

@stale Stale
Copy link

stale bot commented Nov 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Nov 21, 2023
@stale Stale
Copy link

stale bot commented Nov 30, 2023

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Nov 30, 2023
@saurabh100ni saurabh100ni reopened this Dec 20, 2023
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Dec 20, 2023
@leecalcote leecalcote mentioned this pull request Dec 28, 2023
Closed
@leecalcote leecalcote added kind/chore Necessary task area/ci Continuous integration | Build and release language/go Golang related labels Jan 15, 2024
@leecalcote
Copy link
Member

Thank you, @aeswibon!

MUzairS15
MUzairS15 approved these changes Jan 15, 2024
View reviewed changes
Copy link

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@MUzairS15 MUzairS15 merged commit bc57a5d into meshery:master Jan 15, 2024
12 of 36 checks passed
@welcome Welcome
Copy link

welcome bot commented Jan 15, 2024

Thanks for your contribution to the Meshery! 🎉

Meshery Celebration logo
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theBeginner86 theBeginner86 theBeginner86 left review comments

@MUzairS15 MUzairS15 MUzairS15 approved these changes

Assignees
No one assigned
Labels
area/ci Continuous integration | Build and release kind/chore Necessary task language/go Golang related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[chore] update Go to 1.21, and update relevant pkgs
5 participants
@aeswibon @leecalcote @theBeginner86 @MUzairS15 @saurabh100ni