Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update CI workflows #127

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

acald-creator
Copy link
Contributor

Signed-off-by: Antonette Caldwell [email protected]

Description

This PR fixes some of the repetitive workflows.

We should start working toward updating golangci-lint to the latest, and also note that some of the steps in the workflows are already implemented within golangci-lint such as errcheck and gosec.

This current file .golangci.yml is copied from the other repos, so this will need to be updated accordingly.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Antonette Caldwell <[email protected]>
@leecalcote leecalcote added area/ci Continuous integration | Build and release language/go Golang related labels Nov 30, 2022
go-version: 1.19
check-latest: true
cache: true
- name: Create cluster using KinD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acald-creator Why does running the unit tests require a kind cluster?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Revolyssup From the original file at https://github.com/meshery/meshery-app-mesh/blob/master/.github/workflows/ci.yml this is already there. The only difference I did was removed the other checks such as errcheck, vet and gosec because golangci-lint already does this.

This is the same test done through all the adapters repo. Does this section need to be revised or removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this is reflected in the Makefile as well

## Run Golang tests
test: dep-check
	export CURRENTCONTEXT="$(kubectl config current-context)" 
	echo "current-context:" ${CURRENTCONTEXT} 
	export KUBECONFIG="${HOME}/.kube/config"
	echo "environment-kubeconfig:" ${KUBECONFIG}
	GOPROXY=direct GOSUMDB=off GO111MODULE=on go test -v ./...

@acald-creator acald-creator changed the title Update workflows, and make changes recommended [CI] Update CI workflows Jan 29, 2023
@acald-creator
Copy link
Contributor Author

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release language/go Golang related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants