GitHub CI Workflow Enhancements Part 5#403
Merged
ohearnk merged 13 commits intomerzlab:masterfrom Mar 6, 2025
Merged
Conversation
…er optimizations (-O3 => -O2).
Collaborator
Author
|
Notes on the 3 gradient tests failing (both serial & MPI versions):
|
…iminate global namespace exceeded warnings for oneAPI builds. Rename modules for consistency (open/closed shell).
Collaborator
Author
|
Failing test issues have been resolved, so this is now ready for review. |
agoetz
approved these changes
Mar 6, 2025
Collaborator
agoetz
left a comment
There was a problem hiding this comment.
Looks good to me. All serial and mpi tests of the full CPU test suite including f functions pass using oneAPI 2025.0.4.
We will have to address the limitations wrt bundled BLAS/LAPACK. At the very least document that cmake flags -DMKL_HOME=$MKLROOT -DMKL_MULTI_THREADED=FALSE are required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: do not merge this until the 3 gradient tests failures described below are fixed.NOTE: the branch in the PR is based off of the work in #402, so merge that PR first before merging this work.
This PR adds support for building QUICK with the Intel oneAPI compilers (CMake via the
-DCOMPILER=INTELLLVMkeyword). Also Github CI tests for Intel oneAPI builds are added for the following runners:CMake builds:
Notes / Limitations:
-ipoFortran flag due to related issues with interprocedural optimization for libraries).Closes #327.