You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I added new vertex types for the flowchart - a trapezoid and upside-down trapezoid.
The syntax for the new vertex is:
A [/[text here]\]
B [\[text here]/]
The syntax isn't great, I had initially wanted it to be A /text here\ but since the slashes are also part of punctuation and text it caused some issues when building the parser. Maybe there's better options though.
Hi @adamwulf ! Thanks for this PR and I am sorry for the slow response. We are trying to expand the team to get a more steady pace. I think this PR is worthwhile and I would like to merge it but... there a few conflicts. If you take a pull from master and resolve the conflicts I would gladly merge.
One more thing though... It would make a shorter syntax with
A [/text here\]
B [\text here/]
instad of
A [/[text here]\]
B [\[text here]/]
Is there a reason for the use of [ ] in the vertex?
Awesome! I'll look into fixing the conflicts and post back when done. For the syntax, I'll try and change that as well. The reason it for the brackets is that the slashes are also part of punctuation and text groups, so it caused some issues when building the parser. i'll try and come up with something cleaner, or maybe someone with better parser foo can point me in the right direction.
Just pushed up the merged version. Also cleaned up the syntax to be [/text\] and [\text/]. Once i figured out the parser, i added parallelograms too :) [/text/] and [\text\]
Thx! I have now merged your contribution and trapezoids are now supported in mermaid. Could you also add some examples in the docs so that people will know how to use them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added new vertex types for the flowchart - a trapezoid and upside-down trapezoid.
The syntax for the new vertex is:
The syntax isn't great, I had initially wanted it to be
A /text here\but since the slashes are also part of punctuation and text it caused some issues when building the parser. Maybe there's better options though.