PML-385: generator seed for Latent space of theQGAN - #291
Open
CassNot wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for passing a dedicated
torch.GeneratortoPhotonicGenerator.sample_latent()andPhotonicGenerator.generate()This enables reproducible latent batches without advancing PyTorch’s global random-number generator
Backward compatibility is ensured.
Related Issue
PML-385
Type of change
Proposed changes
Added the generator parameter to:
LatentDistribution.sample()NormalLatent.sample()PhotonicGenerator.sample_latent()PhotonicGenerator.generate()Preserved compatibility with custom latent distributions implemented before the new parameter existed.
Added tests covering:
Updated the QGAN documentation and photonic QGAN reproduction notes.
How to test / How to run
Documentation
Checklist
SPHINXOPTS="-W --keep-going -n" make -C docs clean htmlthe docs are built without any warning or errors.