Merge pull request #135 from merkle-open/fix/maintenance

maintenance: node update and move to npm workspaces

.editorconfig

@@ -1,4 +1,4 @@
-# EditorConfig. Frontend. Default. Namics.
+# EditorConfig. Frontend. Default.
 # @see: http://EditorConfig.org
 # install a plugin to your editor: http://editorconfig.org/#download
 # mark: not all plugins supports the same EditorConfig properties

.github/workflows/ci.yml

@@ -5,23 +5,25 @@ name: ci
 on:
   push:
     branches:
+      - main
       - master
       - develop
   pull_request:
     branches:
+      - main
       - master
       - develop
 jobs:
   test:
     strategy:
       matrix:
-        node-version: [10.x, 12.x, 14.x]
-        platform: [ubuntu-latest, windows-latest]
+        node-version: [16.x, 18.x, 20.x]
+        platform: [ubuntu-latest]
     runs-on: ${{ matrix.platform }}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
       - run: npm i

.gitignore

@@ -10,3 +10,6 @@ tmp
 
 # debugging
 *.log
+
+# build
+tsconfig.tsbuildinfo

.husky/pre-commit

@@ -0,0 +1 @@
+npx lint-staged

.node-version

@@ -1 +1 @@
-14.16.1
+20.18.0

.prettierrc.js

@@ -1 +1,3 @@
-module.exports = require('@namics/prettier-config');
+const config = require('@merkle-open/prettier-config');
+
+module.exports = config;

README.md

@@ -232,7 +232,7 @@ The `common-config-webpack-plugin` suite provides typechecks and integration tes
 
 ## Peer dependencies
 
-The `common-config-webpack-plugin` has a direct dependencies to babel and ts.  
+The `common-config-webpack-plugin` has direct dependencies to babel and ts.  
 However if you need to pick a specific version you can use the `js-config-webpack-plugin` or `ts-config-webpack-plugin` which use peer-dependencies instead.
 
 ## License

cli/package.json

@@ -5,15 +5,19 @@
   "homepage": "https://github.com/merkle-open/webpack-config-plugins/",
   "repository": "https://github.com/merkle-open/webpack-config-plugins.git",
   "version": "2.0.3",
-  "author": "Merkle Inc",
+  "main": "dist/config-generator.js",
   "license": "MIT",
+  "author": "Merkle Inc",
+  "engines": {
+    "node": ">=16.13.0",
+    "npm": ">=8.1.0"
+  },
   "bin": {
     "generate-webpack-config": "dist/generate-webpack-config.js"
   },
   "files": [
     "dist"
   ],
-  "main": "dist/config-generator.js",
   "keywords": [
     "webpack",
     "cli"
@@ -37,9 +41,5 @@
     "webpack": "4.46.0",
     "webpack-cli": "4.6.0",
     "webpack-dev-server": "3.11.2"
-  },
-  "engines": {
-    "npm": ">=6",
-    "node": ">=10"
   }
 }

cli/src/config-generator.ts

@@ -178,21 +178,21 @@ function getModuleNamesForConfiguration(configOptions: ConfigLoaderTypeOptions):
 function combinePluginsToWrappers(moduleNamesForConfiguration: Array<PluginName>): Array<PluginName> {
 	// Use Asset Plugin
 	const useAssetConfigWebpackPlugin = !assetConfigWebpackPluginChildren.some(
-		(moduleName) => moduleNamesForConfiguration.indexOf(moduleName) === -1
+		(moduleName) => moduleNamesForConfiguration.indexOf(moduleName) === -1,
 	);
 	if (useAssetConfigWebpackPlugin) {
 		moduleNamesForConfiguration = moduleNamesForConfiguration.filter(
-			(moduleName) => assetConfigWebpackPluginChildren.indexOf(moduleName) === -1
+			(moduleName) => assetConfigWebpackPluginChildren.indexOf(moduleName) === -1,
 		);
 		moduleNamesForConfiguration.push('asset-config-webpack-plugin');
 	}
 	// Use common config plugin
 	const useCommonConfigWebpackPlugin = !commonConfigWebpackPluginChildren.some(
-		(moduleName) => moduleNamesForConfiguration.indexOf(moduleName) === -1
+		(moduleName) => moduleNamesForConfiguration.indexOf(moduleName) === -1,
 	);
 	if (useCommonConfigWebpackPlugin) {
 		moduleNamesForConfiguration = moduleNamesForConfiguration.filter(
-			(moduleName) => commonConfigWebpackPluginChildren.indexOf(moduleName) === -1
+			(moduleName) => commonConfigWebpackPluginChildren.indexOf(moduleName) === -1,
 		);
 		moduleNamesForConfiguration.push('common-config-webpack-plugin');
 	}

cli/src/index.test.ts

@@ -65,7 +65,7 @@ describe('cli', () => {
 			mockInquirer({ options, overwrite: 'no', install: 'no' });
 			await generateConfigCli(process.cwd());
 			expect(logger.mock.calls.length).not.toBe(0);
-		}
+		},
 	);
 
 	test.each(combinations as any)(
@@ -76,7 +76,7 @@ describe('cli', () => {
 			mockInquirer({ options, overwrite: 'no', install: 'no' });
 			await generateConfigCli(process.cwd());
 			expect(mergeLoggerMockCalls(logger)).toMatchSnapshot();
-		}
+		},
 	);
 
 	test.each(combinations as any)(
@@ -88,6 +88,6 @@ describe('cli', () => {
 			mockInquirer({ options, overwrite: 'yes', install: 'no' });
 			await generateConfigCli(tmpSubFolder);
 			expect(mergeLoggerMockCalls(logger)).toMatchSnapshot();
-		}
+		},
 	);
 });

cli/src/index.ts

@@ -26,7 +26,7 @@ export const generateConfigCli = async (cwd = process.cwd()) => {
 		{},
 		...configOptionKeys.map((configOption) => ({
 			[configOption]: options.indexOf(configOption) !== -1,
-		}))
+		})),
 	) as { [key in ConfigOptionKeys]: boolean };
 
 	const result = generateConfigurations(configOptions);
@@ -57,14 +57,14 @@ export const generateConfigCli = async (cwd = process.cwd()) => {
 	if (webpackConfigNeedsUpdateFs) {
 		if (userAllowsWebackOverwrite) {
 			console.log(
-				`✍️  ${webpackConfigExist ? 'Overwriting' : 'Creating'} "${path.relative(cwd, webpackConfigPath)}"\n`
+				`✍️  ${webpackConfigExist ? 'Overwriting' : 'Creating'} "${path.relative(cwd, webpackConfigPath)}"\n`,
 			);
 			writeFileSync(webpackConfigPath, result.webpackConfig);
 		} else {
 			console.log(
 				'⚠️ Skipping writing webpack.config.js\n💡  Add the following code to your webpack.config.js:\n\n' +
 					result.webpackConfig +
-					'\n'
+					'\n',
 			);
 		}
 	} else {
@@ -122,7 +122,7 @@ export const generateConfigCli = async (cwd = process.cwd()) => {
 		}
 		if (configOptions.useCli || configOptions.useDevServer) {
 			console.log(
-				'💡  For more information on available modes please go to https://webpack.js.org/concepts/mode/'
+				'💡  For more information on available modes please go to https://webpack.js.org/concepts/mode/',
 			);
 		}
 	}
@@ -140,7 +140,7 @@ async function spawnInheritAsync(cmd: string, args: Array<string>): Promise<bool
 				// Any exit code other than 0 is considered to be an error.
 				code ? resolve(false) : resolve(true);
 			})
-			.on('error', () => resolve(false))
+			.on('error', () => resolve(false)),
 	);
 }
 

lerna.json

@@ -1,5 +1,5 @@
 {
-  "lerna": "2.11.0",
+  "$schema": "node_modules/lerna/schemas/lerna-schema.json",
   "packages": [
     "cli",
     "packages/*"