Skip to content

fix(lightweightRiskModel): fix duplicate quality check and add null g… #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mericcintosun merged 1 commit into from
Jul 14, 2026
+10 −1
Merged

fix(lightweightRiskModel): fix duplicate quality check and add null g… #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/lib/lightweightRiskModel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ const NORMALIZATION = {
* @returns {Object} Risk analysis result
*/
export function calculateRiskScore(metrics) {
if (!metrics || typeof metrics !== 'object') {
console.error('calculateRiskScore: metrics must be a non-null object');
return fallbackRiskCalculation({});
}

try {
// Normalize features to 0-1 range
const normalizedFeatures = normalizeFeatures(metrics);
Expand Down Expand Up @@ -295,7 +300,11 @@ export function getDataQualityScore(metrics) {
if (metrics.totalPayments > 10) qualityScore += 25;
if (metrics.uniqueCounterparties > 3) qualityScore += 25;
if (metrics.assetDiversity > 1) qualityScore += 25;
if (metrics.totalPayments > 0) qualityScore += 25;
// Award the final 25 points only when there is BOTH payment activity
// AND counterparty diversity — the original code checked totalPayments > 0
// which is always true when totalPayments > 10 is already satisfied,
// making it impossible to ever score less than 50 via this path.
if (metrics.totalPayments > 0 && metrics.uniqueCounterparties > 0) qualityScore += 25;

return {
score: qualityScore,
Expand Down