Skip to content

Conversation

@mergesort
Copy link
Owner

We all love Swift Concurrency don't we?

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

@@ -1 +1 @@
public typealias StorableItem = Codable & Sendable
public typealias StorableItem = Codable & Sendable & SendableMetatype

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P0] Constrain types to nonexistent SendableMetatype

The change introduces a new SendableMetatype requirement on StorableItem (and AsyncValueSubject) but no such protocol or type alias exists anywhere in the repository or in Swift’s standard library. Adding this constraint causes every use of StorableItem or AsyncValueSubject to fail to compile because the compiler cannot resolve SendableMetatype. Unless a definition and conformances are provided, the package will not build.

Useful? React with 👍 / 👎.

@mergesort
Copy link
Owner Author

@codex fix the fact that this isn't backwards compatible. I just realized that this fix will only work when the Swift compiler is 6.2+, so please conditionally compile the type changes made only when the compiler is 6.2+, otherwise keep the StorableItem type as it previously was.

@chatgpt-codex-connector
Copy link

Summary

Testing

  • ⚠️ swift test (fails: HTTP 403 while cloning remote dependencies)

View task →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant