Skip to content

feat(expenses): add URL-backed filters and pagination - #217

Merged
K1NGD4VID merged 2 commits into
mergepay:mainfrom
Taiye21:fix/issue-207
Sep 2, 2026
Merged

feat(expenses): add URL-backed filters and pagination#217
K1NGD4VID merged 2 commits into
mergepay:mainfrom
Taiye21:fix/issue-207

Conversation

@Taiye21

@Taiye21 Taiye21 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Add the neobrutalist expense filter panel with debounced search, payer/status/asset filters, page-size controls, URL synchronization, clear-all behavior, and client-side pagination.

Closes #207

@drips-wave

drips-wave Bot commented Aug 27, 2026

Copy link
Copy Markdown

@Taiye21 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mergekeeper

mergekeeper Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

MergeKeeper review

Scope: in scope for linked issue #207.
Verdict: clean

Successfully implemented search, multi-select filtering, pagination, and URL synchronization for expense lists according to requirements.

Reviewed commit: dcc90fdf92eda9d8d4c7266f36246b293738a48b.
CI and merge eligibility are checked separately.

@Taiye21

Taiye21 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Hi @Cjay-Cyber-2, the implementation for issue #207 is pushed on the requested fork branch and this PR is ready for review. Closes #207.

@Taiye21
Taiye21 force-pushed the fix/issue-207 branch 2 times, most recently from 8ce2c25 to 7b1d6b2 Compare August 28, 2026 08:30
@Taiye21

Taiye21 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

@mergepay Merge conflicts resolved against latest main. Rebased fix/issue-207 onto upstream/main and pushed — new head: dcc90fd.

Conflict files: src/app/(app)/groups/[id]/page.tsx
Validation: git diff --check clean; no conflict markers; reviewed types/imports against main (no node_modules present, so tsc/lint skipped).

Note: upstream main had rewritten this page in #453 (filter toolbar layout). I kept the new layout and integrated the PR's ExpenseListFilters (URL-backed search + payer/asset/status filters) + pagination, replacing the older ExpenseFilterToolbar.

Please review / re-run CI when convenient. Thanks!

@K1NGD4VID
K1NGD4VID merged commit e2b407b into mergepay:main Sep 2, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Search, Multi-Select Filtering, and Pagination for Expense Lists

3 participants