feat(anchors): add interactive SEP-24 transfer modal - #216
Conversation
|
@Taiye21 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Needs changes Missing unit tests for the anchor polling mechanism specified in the testing requirements.
Reviewed commit: |
There was a problem hiding this comment.
Needs changes
Missing unit tests for the anchor polling mechanism specified in the testing requirements.
src/lib/__tests__/anchor.test.ts: Create src/lib/tests/anchor.test.ts to write unit tests for the polling mechanism ensuring it stops polling upon terminal events as requested in the issue test plan.
Reviewed commit: abf2453d2f32860fac7bc223bf81256b8fedcdc1.
|
Hi @Cjay-Cyber-2, the implementation for issue #210 is pushed on the requested fork branch and this PR is ready for review. Closes #210. |
|
MergeKeeper review Scope: in scope for linked issue The pull request correctly implements the SEP-24 interactive anchor deposit and withdrawal workflow with modal handling, polling behavior, and corresponding unit tests. Reviewed commit: |
|
Added |
|
Needs review Linked to The pull request modifies and removes unrelated code (such as expense creation logic and invite hooks) that falls outside the scope of issue #210. Reviewed commit: |
# Conflicts: # src/hooks/useAnchorTransaction.ts
|
MergeKeeper review unavailable AI provider review response did not contain valid JSON No approval or merge action was taken. |
Add a reusable interactive anchor transfer modal and polling hook. SEP-24 sessions are shown in a responsive iframe with a new-tab fallback, status feedback, retries, and terminal polling behavior.
Closes #210