Skip to content

feat(anchors): add interactive SEP-24 transfer modal - #216

Merged
K1NGD4VID merged 7 commits into
mergepay:mainfrom
Taiye21:fix/issue-210
Sep 2, 2026
Merged

feat(anchors): add interactive SEP-24 transfer modal#216
K1NGD4VID merged 7 commits into
mergepay:mainfrom
Taiye21:fix/issue-210

Conversation

@Taiye21

@Taiye21 Taiye21 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Add a reusable interactive anchor transfer modal and polling hook. SEP-24 sessions are shown in a responsive iframe with a new-tab fallback, status feedback, retries, and terminal polling behavior.

Closes #210

@drips-wave

drips-wave Bot commented Aug 27, 2026

Copy link
Copy Markdown

@Taiye21 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mergekeeper

mergekeeper Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Needs changes

Missing unit tests for the anchor polling mechanism specified in the testing requirements.

  • src/lib/__tests__/anchor.test.ts: Create src/lib/tests/anchor.test.ts to write unit tests for the polling mechanism ensuring it stops polling upon terminal events as requested in the issue test plan.

Reviewed commit: abf2453d2f32860fac7bc223bf81256b8fedcdc1.

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes

Missing unit tests for the anchor polling mechanism specified in the testing requirements.

  • src/lib/__tests__/anchor.test.ts: Create src/lib/tests/anchor.test.ts to write unit tests for the polling mechanism ensuring it stops polling upon terminal events as requested in the issue test plan.

Reviewed commit: abf2453d2f32860fac7bc223bf81256b8fedcdc1.

@Taiye21

Taiye21 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Hi @Cjay-Cyber-2, the implementation for issue #210 is pushed on the requested fork branch and this PR is ready for review. Closes #210.

@mergekeeper

mergekeeper Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

MergeKeeper review

Scope: in scope for linked issue #210.
Verdict: clean

The pull request correctly implements the SEP-24 interactive anchor deposit and withdrawal workflow with modal handling, polling behavior, and corresponding unit tests.

Reviewed commit: 3e883a7046102966909afe429c477e26439e8cd1.
CI and merge eligibility are checked separately.

@Taiye21

Taiye21 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Added src/lib/__tests__/anchor.test.ts covering terminal SEP-24 statuses, continued pending polling, and persistent polling-failure cutoff. The fix is pushed to fix/issue-210.

@mergekeeper

mergekeeper Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Needs review

Linked to #210, but the diff does not match the issue scope.

The pull request modifies and removes unrelated code (such as expense creation logic and invite hooks) that falls outside the scope of issue #210.

Reviewed commit: bd9d1e8e514844118da6e9b93ad77e7ba7b82adb.

@Taiye21

Taiye21 commented Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

✅ Merge conflicts resolved against upstream main and anchor changes preserved in commit a48dc7a. @mergepay please review the updated branch.

# Conflicts:
#	src/hooks/useAnchorTransaction.ts
@mergekeeper

mergekeeper Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

MergeKeeper review unavailable

AI provider review response did not contain valid JSON

No approval or merge action was taken.

@K1NGD4VID
K1NGD4VID merged commit 42fc98c into mergepay:main Sep 2, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement SEP-24 Anchor Interactive Deposit and Withdrawal Flow

3 participants