Fix: [25 MRG] Pose pack: yoga_warrior_ii_side (fitness)

[itsok143211-maker]

This PR was generated fully autonomously by an AI agent to claim the bounty.

Closes #50
Issue: #50

[xiaoliu6ai]

QA Verification Report — PoseGuide PR #183

Target PR: #183
Head commit SHA: 05ec44bdfdd0487a661c6f44ae654625b82f013c (branch fix/issue-50-1786267945, author @itsok143211-maker)
Verified by: @xiaoliu6ai
Verified at: 2026-08-15 13:52 HKT

What the PR does

Adds the Yoga Warrior II (Side View) pose pack, closing bounty issue #50 ([25 MRG] Pose pack: yoga_warrior_ii_side — "Pose + catalog + tests" acceptance):

1. data/poses/yoga_warrior_ii_side.json — new pose template (+33)
2. poses/data.py — trailing-newline-only edit (no functional change)

Commands run (PR head checked out, Python 3.13)

• JSON syntax check — PASS
• Schema validation (validate_pose_file / load_poses from src/poseguide/data/schema.py) — FAIL
  • pydantic.ValidationError: description — Extra inputs are not permitted [extra_forbidden]
  • The Pose model uses ConfigDict(extra="forbid") and has no description field; the new file adds one. On master, 0 of 76 pose files carry a description field — this file is the only non-conforming one.
• pytest -q (full suite) — FAIL, 2 failed / 40 passed / 5 skipped
  • tests/test_schema.py::test_all_shipped_poses_validate — pydantic ValidationError on the new file
  • tests/test_web_demo.py::test_web_catalog_is_synced_with_poseguide_data — web catalog is out of sync: it is missing yoga_warrior_ii_side
• Joint anatomy check — PASS (all 13 canonical JOINT_KEYS present, including the 4 REQUIRED_JOINTS l_shoulder/r_shoulder/l_hip/r_hip; all coordinates within 0–1; difficulty: "medium" allowed)

GitHub Actions status

No check runs returned for head commit 05ec44bd at review time (check-runs API empty). CI status could not be confirmed; locally the test suite fails as above.

Findings (issues)

1. 🔴 Invalid schema — blocks the shipped-pose pipeline: the new file's description field violates the extra="forbid" Pose schema, so load_poses() (which validates every data/poses/*.json) raises a ValidationError. This is a real integration break, not just a lint nit.

2. 🔴 Web catalog not synced: tests/test_web_demo.py asserts the web demo catalog equals the shipped pose set. The new pose id yoga_warrior_ii_side is missing from the web catalog, so the test fails. (The edit to poses/data.py is cosmetic and does not register the pose anywhere.)

3. 🟡 No tests added: issue [25 MRG] Pose pack: yoga_warrior_ii_side (fitness) #50's acceptance checklist is "Pose + catalog + tests"; the PR ships no new test coverage for the pose.

What checks out

• Joint data quality is good (full 13-joint canonical skeleton, correct required joints, sensible normalized coordinates)
• Tags/difficulty/standing all match the schema vocabulary
• Mergeability: mergeable=True, no conflict

Evidence status

• Pose data: provided but invalid (fails the shipped-pose schema)
• Catalog integration: missing (web catalog out of sync; no functional registration)
• Tests: missing (and the existing suite now fails 2 tests)

Recommendation

Request Changes

• Remove the description field from data/poses/yoga_warrior_ii_side.json (or add description support to the Pose schema if intended project-wide — but removing it is the minimal fix)
• Sync the web demo catalog with the new pose id so test_web_demo.py passes
• Run pytest -q locally and ensure test_all_shipped_poses_validate and test_web_catalog_is_synced_with_poseguide_data are green before re-requesting review