Skip to content

feat: writing cohesion rubric + samples list CLI + batch CSV export (Fixes #66, #59, #32) - #121

Open
laurentketterle-hub wants to merge 1 commit into
mergeos-bounties:masterfrom
laurentketterle-hub:feat/writing-rubric-batch-csv
Open

feat: writing cohesion rubric + samples list CLI + batch CSV export (Fixes #66, #59, #32)#121
laurentketterle-hub wants to merge 1 commit into
mergeos-bounties:masterfrom
laurentketterle-hub:feat/writing-rubric-batch-csv

Conversation

@laurentketterle-hub

Copy link
Copy Markdown

Summary

Writing cohesion/coherence rubric, samples list CLI, and batch CSV export for NokaMan.

Changes

Writing cohesion/coherence rubric (Fixes #66):

  • New writing_cohesion.py module with 4 offline dimensions:
    • Cohesion (pronoun/connective density, lexical variety)
    • Coherence (sentence flow, paragraph connection)
    • Paragraph structure (topic sentences, length balance)
    • Transition quality (sentence-starting transition words)
  • score_writing_cohesion() and score_writing_sample() functions
  • Deterministic surface-level heuristics (no network/LLM required)

CLI samples list (Fixes #59):

  • New nokaman samples list command
  • Optional --language / -l and --skill / -s filters
  • Rich table with file, language, skill, and text preview columns

Batch CSV export (Fixes #32):

  • Added --format csv / -f csv option to nokaman eval batch
  • Exports results as CSV: file, language, skill, score, cefr, expected_cefr, distance

Tests

  • 9 new tests in test_writing_cohesion.py — all passing (75/75 total)
  • All existing tests continue to pass

Fixes #66, Fixes #59, Fixes #32

- Add writing_cohesion.py rubric module with 4 offline dimensions:
  cohesion, coherence, paragraph_structure, transition_quality
- Add 'nokaman samples list --language --skill' CLI command
  with rich table output showing sample files, language, skill, text preview
- Add '--format csv' option to 'nokaman eval batch' for teacher workflows
- 9 new tests in test_writing_cohesion.py (all passing)

Fixes mergeos-bounties#66, Fixes mergeos-bounties#59, Fixes mergeos-bounties#32
@laurentketterle-hub

Copy link
Copy Markdown
Author

/attempt 66
/attempt 59
/attempt 32

@laurentketterle-hub

Copy link
Copy Markdown
Author

Friendly ping - PR open for 3 days. Anything needed to move this forward? Thanks!

@laurentketterle-hub

Copy link
Copy Markdown
Author

Hi maintainer! Just a friendly ping on this PR - it has been ready for review. Any feedback or updates needed? Thanks!

3 similar comments
@laurentketterle-hub

Copy link
Copy Markdown
Author

Hi maintainer! Just a friendly ping on this PR - it has been ready for review. Any feedback or updates needed? Thanks!

@laurentketterle-hub

Copy link
Copy Markdown
Author

Hi maintainer! Just a friendly ping on this PR - it has been ready for review. Any feedback or updates needed? Thanks!

@laurentketterle-hub

Copy link
Copy Markdown
Author

Hi maintainer! Just a friendly ping on this PR - it has been ready for review. Any feedback or updates needed? Thanks!

@2754504154-dev

Copy link
Copy Markdown

🔍 QA Verification Report — PR #121 (Bounty #64)

Target: #121 — feat: writing cohesion rubric + samples list CLI + batch CSV export
Head SHA: ce706cbfbbd9e0d7b26c391621fdec62fba6b76f

Commands run

Command Result
git checkout ce706cb ✅ success
JSON validity (12 files: rubrics, schemas, fixtures) ✅ all valid
python3.11 -m py_compile (12+ test files) ✅ all OK
pytest -q (local) 75 passed, 1 warning in 0.52s

GitHub Actions

No check-runs visible at review time.

Manual verification

  • Cohesion rubric data (EN/JA/KO rubrics), listening samples, fairness fixtures all parse correctly.
  • Full test suite green: 75 passed — writing cohesion rubric, metrics, contracts, fairness, SDK, language coverage all covered.

Evidence status

  • Test output: ✅ provided (75 passed)
  • Feature behavior: ✅ verified via local execution

Final recommendation

Approve. Feature implemented as described; full suite passes; data files valid.

Verifier: @2754504154-dev

@laurentketterle-hub

Copy link
Copy Markdown
Author

Hi maintainer! Just a friendly ping on this PR - it has been ready for review. Any feedback or updates needed? Thanks!

1 similar comment
@laurentketterle-hub

Copy link
Copy Markdown
Author

Hi maintainer! Just a friendly ping on this PR - it has been ready for review. Any feedback or updates needed? Thanks!

@laurentketterle-hub

Copy link
Copy Markdown
Author

/claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants