feat: add --json/--out flags to lappa path resample + CLI smoke tests (Fixes #52) - #100
Open
laurentketterle-hub wants to merge 1 commit into
Conversation
Author
|
/attempt 52 |
1 task
Author
|
Friendly ping 👋 — this PR has been open for 3 days. Is there anything needed for review? Thanks! |
laurentketterle-hub
force-pushed
the
feat/resample-fixture-rewrite-52
branch
from
August 7, 2026 01:10
8410469 to
c349af4
Compare
Implements the CLI lappa path resample --step-m fixture rewrite for bounty mergeos-bounties#52. - --json flag on path stats: emits a single JSON object with points, path_length_m, net_displacement_m - --json flag on path resample: machine-readable output including step_m, original_points, original_length_m - --out / -o flag on path resample: writes resampled points as a valid JSON fixture - 43 CLI smoke tests covering json output, out writing, round-trip validation, and all fixture types Fixes mergeos-bounties#52 Signed-off-by: laurentketterle-hub <noreply@users.noreply.github.com>
laurentketterle-hub
force-pushed
the
feat/resample-fixture-rewrite-52
branch
from
August 7, 2026 01:11
c349af4 to
b623cea
Compare
Author
|
/claim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the CLI
lappa path resample --step-mfixture rewrite for bounty #52.Changes
CLI additions (
packages/server/src/lappa/cli.py)--jsonflag onpath stats: emits a single JSON object withpoints,path_length_m,net_displacement_mto stdout--jsonflag onpath resample: same machine-readable output, plusstep_m,original_points,original_length_m--out/-oflag onpath resample: writes resampled points as a valid JSON fixture withname,points,path_length_m,step_m; creates parent directories automatically--jsonand--outare used, the JSON output includes theoutkey with the resolved pathTests (
packages/server/tests/test_resample_cli_fixture_rewrite.py)43 new CLI smoke tests:
--jsontests (line, square loop, hexagon fixtures)--jsontests (default step, 0.5m, 1.0m, diamond, L-shape, large step)--outtests (file validity, round-trip, combined --json, custom step, parent dir creation)--jsonand writable via--out)Evidence
Closes #52