[WC-3165] BarcodeGenerator: Enhancements #1972
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordan-st
changed the title
yordan-st
force-pushed
the
feat/WC-3165_BarcodeGenerator-enhancements
branch
from
c6f945d to
4538743
Compare
iobuhov
requested changes
Nov 11, 2025
packages/pluggableWidgets/barcode-generator-web/src/components/BarcodeRenderer.tsx
Outdated
Show resolved
Hide resolved
iobuhov
requested changes
Nov 11, 2025
packages/pluggableWidgets/barcode-generator-web/src/BarcodeGenerator.tsx
Outdated
Show resolved
Hide resolved
yordan-st
force-pushed
the
feat/WC-3165_BarcodeGenerator-enhancements
branch
3 times, most recently
from
2137d49 to
c7c502b
Compare
iobuhov
reviewed
Nov 12, 2025
packages/pluggableWidgets/barcode-generator-web/src/hooks/useRenderBarcode.ts
Show resolved
Hide resolved
yordan-st
force-pushed
the
feat/WC-3165_BarcodeGenerator-enhancements
branch
from
9e311b3 to
e7b8d90
Compare
iobuhov
reviewed
Nov 17, 2025
Comment on lines
+8
to
+10
| const ref = useRenderBarcode(); | ||
| const { allowDownload } = useBarcodeConfig(); | ||
| const { downloadBarcode } = useDownloadBarcode({ ref }); |
iobuhov
reviewed
Nov 17, 2025
Comment on lines
+14
to
+17
| if (!svgElement) { | ||
| console.error("SVG element not found for download"); | ||
| return; | ||
| } |
yordan-st
force-pushed
the
feat/WC-3165_BarcodeGenerator-enhancements
branch
from
e7b8d90 to
ad28a65
Compare
yordan-st
force-pushed
the
feat/WC-3165_BarcodeGenerator-enhancements
branch
from
ad28a65 to
5d9e04d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description