[WC-3079] Prevent Gallery from breaking in iframes #1897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iobuhov
requested changes
Sep 16, 2025
r0b1n
force-pushed
the
There-is-no-escaping-Mr-Anderson
branch
from
fcf4a41 to
3bdb8a9
Compare
iobuhov
previously approved these changes
Sep 16, 2025
r0b1n
force-pushed
the
There-is-no-escaping-Mr-Anderson
branch
from
3bdb8a9 to
1c3760d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Gallery was string to get the top level window object, but this object is not available due to security reasons when the app is working in an iframe. Use
globalThisto get the "local" window object.