-
Notifications
You must be signed in to change notification settings - Fork 55
[WC-3081] Combobox: Debounce datasource filter #1882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0b1n
reviewed
Sep 9, 2025
packages/pluggableWidgets/combobox-web/src/__tests__/SingleSelection.spec.tsx
Outdated
Show resolved
Hide resolved
r0b1n
reviewed
Sep 9, 2025
packages/pluggableWidgets/combobox-web/src/helpers/BaseDatasourceOptionsProvider.ts
Outdated
Show resolved
Hide resolved
r0b1n
reviewed
Sep 9, 2025
packages/pluggableWidgets/combobox-web/src/helpers/BaseDatasourceOptionsProvider.ts
Outdated
Show resolved
Hide resolved
r0b1n
reviewed
Sep 9, 2025
packages/pluggableWidgets/combobox-web/src/helpers/BaseDatasourceOptionsProvider.ts
Outdated
Show resolved
Hide resolved
1ac1014
to
57a30a1
Compare
iobuhov
reviewed
Sep 12, 2025
packages/pluggableWidgets/combobox-web/src/helpers/BaseDatasourceOptionsProvider.ts
Outdated
Show resolved
Hide resolved
f7758c4
to
fce9ace
Compare
r0b1n
reviewed
Sep 15, 2025
r0b1n
reviewed
Sep 15, 2025
packages/pluggableWidgets/combobox-web/src/helpers/Association/BaseAssociationSelector.ts
Outdated
Show resolved
Hide resolved
r0b1n
reviewed
Sep 15, 2025
packages/pluggableWidgets/combobox-web/src/helpers/BaseDatasourceOptionsProvider.ts
Outdated
Show resolved
Hide resolved
r0b1n
reviewed
Sep 15, 2025
packages/pluggableWidgets/combobox-web/src/helpers/Association/BaseAssociationSelector.ts
Outdated
Show resolved
Hide resolved
32a0c00
to
7daf2b2
Compare
r0b1n
previously approved these changes
Sep 17, 2025
7daf2b2
to
1bd0967
Compare
1bd0967
to
bbc4b22
Compare
leonardomendix
approved these changes
Sep 24, 2025
gjulivan
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description
This PR introduces a new property, allowing users to control the debounce interval (in ms) for datasource filter operations. This improves performance and user experience for large datasets and rapid input.
What should be covered while testing?