[WC-2991][WC-2919][WC-2960][WC-2986] Rich Text: add image to entity, maintain image ratio, support line breaks #1625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjulivan
force-pushed
the
rte-image-entity
branch
from
28804c3 to
698aeb0
Compare
gjulivan
changed the title
gjulivan
force-pushed
the
rte-image-entity
branch
4 times, most recently
from
099426f to
c351ab3
Compare
gjulivan
changed the title
gjulivan
changed the title
gjulivan
force-pushed
the
rte-image-entity
branch
3 times, most recently
from
65777c9 to
e842efe
Compare
samuelreichert
previously requested changes
Jun 23, 2025
packages/pluggableWidgets/rich-text-web/src/components/Editor.tsx
Outdated
Show resolved
Hide resolved
packages/pluggableWidgets/rich-text-web/src/components/ModalDialog/ImageDialog.tsx
Outdated
Show resolved
Hide resolved
packages/pluggableWidgets/rich-text-web/src/components/ModalDialog/ImageDialog.tsx
Outdated
Show resolved
Hide resolved
packages/pluggableWidgets/rich-text-web/src/utils/modules/resize.ts
Outdated
Show resolved
Hide resolved
packages/pluggableWidgets/rich-text-web/src/utils/modules/resize.ts
Outdated
Show resolved
Hide resolved
packages/pluggableWidgets/rich-text-web/src/utils/modules/resize.ts
Outdated
Show resolved
Hide resolved
packages/pluggableWidgets/rich-text-web/src/utils/modules/resize.ts
Outdated
Show resolved
Hide resolved
gjulivan
force-pushed
the
rte-image-entity
branch
from
229599d to
5349280
Compare
samuelreichert
previously approved these changes
Jun 24, 2025
packages/pluggableWidgets/rich-text-web/src/components/ModalDialog/ImageDialog.tsx
Show resolved
Hide resolved
gjulivan
force-pushed
the
rte-image-entity
branch
from
5349280 to
64b2477
Compare
gjulivan
force-pushed
the
rte-image-entity
branch
from
64b2477 to
366b86e
Compare
gjulivan
force-pushed
the
rte-image-entity
branch
from
e5fbddb to
854e1f9
Compare
leonardomendix
approved these changes
Jul 1, 2025
samuelreichert
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
allow rich text to receive images from external widget by using custom events bubble.
Description