[WC-2922]: Add aggregate utils for charts #1562
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahmanunver
force-pushed
the
wc-2922_charts-aggregate-utils
branch
from
068af2d to
190c64e
Compare
gjulivan
reviewed
May 8, 2025
| const pts = | ||
| line.aggregationType === "none" | ||
| ? dataPoints | ||
| : aggregateDataPoints(line.aggregationType, dataPoints); |
There was a problem hiding this comment.
checking type none is already done in the function aggregateDataPoints. this is no longer needed
|
i think we can remove all maybe need to add |
rahmanunver
force-pushed
the
wc-2922_charts-aggregate-utils
branch
2 times, most recently
from
c47560c to
6314070
Compare
rahmanunver
force-pushed
the
wc-2922_charts-aggregate-utils
branch
from
29a1379 to
c2f33aa
Compare
gjulivan
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Added a new
aggregations.tsin the charts utilities to be used instead of the deprecated plotly.js aggregations.What should be covered while testing?
All Charts (area, bar, bubble, column, line, time-series) should have working aggregations displayed in the charts/graphs.