Skip to content

Conversation

MxKevinBeqo
Copy link
Contributor

Checklist

  • Contains unit tests ❌
  • Contains breaking changes ❌
  • Compatible with: MX 10
  • Did you update version and changelog? ✅
  • PR title properly formatted ([XX-000]: description)? ✅
  • Works in Android ✅
  • Works in iOS ✅
  • Works in Tablet ✅

Feature specific

  • Comply with designs ✅
  • Comply with PM's requirements ✅

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

Fixing an issue with the virtual scroll in the Gallery widget.

Relevant changes

Addition of a prop in the FlatList component to control the onEndReachedThreshold value.

What should be covered while testing?

Case of fast scrolling through a list of over 50 items.

@MxKevinBeqo MxKevinBeqo requested a review from a team as a code owner October 6, 2025 12:47
@MxKevinBeqo MxKevinBeqo changed the title fix(gallery-native): virtual scrolling issue [MOO-2029]: fix for virtual scrolling issue on main Oct 7, 2025
@UrazAkgultan UrazAkgultan force-pushed the fix/gallery-native-scroll branch from 55903ac to f1f57d0 Compare October 7, 2025 08:28
Copy link
Collaborator

@UrazAkgultan UrazAkgultan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please bump the widget version?

@MxKevinBeqo
Copy link
Contributor Author

A quick update, after discussing the version with Uraz, the conclusion is that the version is already bumped by Harun following the react-native-device-info update. Which is unreleased, and is linked with 2.0.1 version (for which this fix also applies to).

TLDR: The version will remain 2.0.1 since it is not released yet.

cc: @UrazAkgultan , @NikolaSimsic

@UrazAkgultan
Copy link
Collaborator

@MxKevinBeqo Just to clarify: there is currently no unreleased version on the main branch.
So this change should indeed be versioned as 2.0.1 in this PR.

@UrazAkgultan
Copy link
Collaborator

The version of this widget was bumped to 2.0.1, but no changelog was added, which caused some confusion. Let's add the changes made in version 2.0.1 to the release notes and bump the widget version to 2.0.2.

@UrazAkgultan UrazAkgultan force-pushed the fix/gallery-native-scroll branch from 8603025 to 00d5549 Compare October 14, 2025 08:13
@NikolaSimsic NikolaSimsic merged commit 307c987 into main Oct 15, 2025
22 of 23 checks passed
@NikolaSimsic NikolaSimsic deleted the fix/gallery-native-scroll branch October 15, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants