Skip to content

[MOO-1785] Upgrade Detox to 20.x #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

NikolaSimsic
Copy link
Contributor

No description provided.

@NikolaSimsic NikolaSimsic requested a review from a team as a code owner February 17, 2025 14:17
- name: "Setup JDK 17"
uses: actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9 # v4.2.1
- name: "Setup JDK"
uses: actions/setup-java@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good security practice to pin the version at a specific commit. We also use a job that checks for this and it's failing so please use a specific commit instead of a version number (you can write specific version name in a comment next to it).

This applies to all actions, not just this one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants