Skip to content

Proofreading task for ms-windows #9547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

OlufunkeMoronfolu
Copy link
Collaborator

Not a lot was here. However, notable ones are:

  • Removing the marketplace image, as it was outdated and its addition or removal does not impact the documentation
  • Recreating the "setup" image to improve readability

Copy link
Collaborator

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OlufunkeMoronfolu
Nice updates.
Can you look into the missing image.
Also, can you either follow up on my other comment in the wsc Slack channel, or add it as a Jira issue to pick up later?
Thanks.


{{< figure src="/attachments/deployment/on-premises-design/ms-windows/18580733.png" >}}
{{< figure src="/attachments/deployment/on-premises-design/ms-windows/ms-windows-setup.png" >}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new image doesn't seem to be part of the PR.
Have you forgotten to add it - or is it in a different folder somewhere?
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. Now fixed.

Follow the instructions below and replace *[Name]* with the name of the rule in the table above, *[Pattern]* with the regular expression pattern, and *[Rewrite URL]* with the Rewrite URL.

{{% alert color="info" %}}
Some patterns contain a trailing slash, `/`, when they need to point to an exact path (for example, `/ws-doc/mydoc/1234`).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this example confusing as the example given does not include a trailing slash.
With a lot of thought I can see what it means (the pattern for ws-doc is ^(ws-doc/)(.*) which has a trailing slash as part of it, which means that the path has to begin with ws-doc/ and cannot be ws-documentation/.

Also, the example has a leading / which doesn't seem to be in the patterns.

If you can't get a quick response from the Slack channel, then perhaps put this on the Jira backlog to pick up later?

Copy link
Collaborator Author

@OlufunkeMoronfolu OlufunkeMoronfolu May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your insight and pointing this out. Following up right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants