Skip to content

Conversation

jowussler
Copy link
Contributor

updated the documentation of the platform supported OPC UA connector to reflect the changes of the latest 1.1.0 release that happened today.

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jowussler
Thanks for the PR.
I have proofread it, but have a couple of questions about your use of the term object to describe a list.
Feel free to Slack me if you want to discuss this face-to-face rather than having a back-and-forth in the GitHub comments.
Thanks
Mark

Copy link
Collaborator

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jowussler
I've made some suggestions to make the use of the domain model clearer. Do these look good?

jowussler and others added 2 commits April 14, 2025 10:18
…t/modules/opc-ua-connector.md

Co-authored-by: Mark van Ments <[email protected]>
…t/modules/opc-ua-connector.md

Co-authored-by: Mark van Ments <[email protected]>
@jowussler
Copy link
Contributor Author

@MarkvanMents
Both suggestions look good to me and I committed them.

Copy link
Collaborator

@MarkvanMents MarkvanMents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging.

@MarkvanMents MarkvanMents merged commit c5fa99d into mendix:development Apr 14, 2025
2 checks passed
@jowussler jowussler deleted the opcua-connector-v1.1.0 branch August 7, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants