Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to download select #269

Merged
merged 3 commits into from
Jan 14, 2021
Merged

Fix link to download select #269

merged 3 commits into from
Jan 14, 2021

Conversation

northerner
Copy link
Contributor

Using the "text" property as a placeholder for the download select was
breaking the selection of the first item in the list. This is a labeled
select box so a placeholder value was not necessary anyway.

#223

Using the "text" property as a placeholder for the download select was
breaking the selection of the first item in the list. This is a labeled
select box so a placeholder value was not necessary anyway.

#223
@northerner northerner requested review from mrhead and jcbpl January 11, 2021 13:16
@mrhead
Copy link
Contributor

mrhead commented Jan 13, 2021

@northerner What do we show instead of "Choose download"? TinyMCE API is hard to follow. 😳

@northerner
Copy link
Contributor Author

@northerner What do we show instead of "Choose download"? TinyMCE API is hard to follow. 😳

It just defaults to the first download available, like podcasts dropdown.

Copy link
Contributor

@mrhead mrhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@northerner northerner merged commit 1c92f46 into master Jan 14, 2021
@northerner northerner deleted the fix-link-to-download-select branch January 14, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants