Feat/Avatar builder and component #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3a7317e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TGlide
reviewed
Jan 15, 2025
Instead of calling `getters` with the props for the Avatar builder, wrap the entire `new Avatar()` call in `$derived`. Causes a new instance to be created if the props change, resetting the loading status. call in `$derived`
- Previous commit only reset loading status and reloaded the image correctly if the `src` prop was changed. If `delayMs` wash change, the loading status was reset, but `onload()` never fired. Reverting to using `getters` - Add `MaybeGetter` to Avatar props
- Remove MaybeGetter from onLoadingStatusChange - Remove Synced from loadingStatus - Put onLoadingStatusChange into an $effect - Added `dark:` to example inputs and removed the explicit text color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Avatar builder and component, ported from melt-ui:
A couple additional items that were related (let me know if you would like these broken out in a different PR):
srcproptext-gray-100(it was black on dark gray when not in dark mode)