Fix bounds #922
Closed
Fix bounds #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite Bounding Rect allows to properly takes in account anchor and transform for any me.Sprite object (including me.GUI), including proper detection of pointer Events. this is first partial implementation only for me.Sprite objects, as applying the same to the base me.Renderable class will trigger further breaking changes in me.Entity TODO : - me.Renderable class, including me.Entity - properly fix the debugPanel (Sprite BB drawing is off for now)
|
Hi Adrian, looks good ! Couple of things :
|
|
I also commented on the other pull request (I see this one also includes the changes on me.Sprite, so let's try to close the other one first, so that this one can reflect it too) |
|
see #1008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #848. I am not completely sure if this is the best solution. There is one test case in
droptarget-spec.jsthat fails and I'm not rather sure how to fix it. Waiting for your comments. I haven't deleted Entity in this case. I'll do it once this solution is alright