You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds a check that the documentation still describes the code: paths, CLI flags the parser really defines, importable names, the declared Python floor, install extras.
A claim is called broken only when history shows the project had the thing and removed it. So a tutorial path or an illustration is a skip with a reason, not a false alarm.
What it says on this repo today:
ok paths: 64 checked, 53 skipped
ok cli-flags: 47 checked
ok versions: 1 checked
Nothing contradicted. 112 claims checked, 53 not judged.
fetch-depth: 0 is not optional, and the action refuses without it. Measured on pallets/click: a full clone reports 1 broken and exits 1, while the same repository at --depth 1 reports Nothing contradicted and exits 0. Since actions/checkout gives depth 1 by default, the quiet version of this check is a permanently green gate that judged nothing.
This pull request adds a new GitHub Actions workflow, docs-check.yml, which runs melbinjp/docproof to verify that the documentation claims match the actual code in the repository. The workflow runs on pushes and pull requests to main and properly configures fetch-depth: 0 to allow the action to inspect historical states. The configuration is sound and fulfills its intended purpose.
Findings
[WARN]
.github/workflows/docs-check.yml, line 36 - The melbinjp/docproof action is referenced using the @main branch. Since other actions in this repository (such as actions/checkout@v7 in this file, as well as others in ci.yml) use version bounds, adding a dependency with no upper bound at all introduces the risk of unexpected breakages if backwards-incompatible changes are pushed to docproof. Consider pinning this to a specific release tag or commit SHA.
Verdict
VERDICT: comment
This review never edits code or force-blocks a merge.No blocking issues were found, so this PR was auto-approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check that the documentation still describes the code: paths, CLI flags the parser really defines, importable names, the declared Python floor, install extras.
A claim is called broken only when history shows the project had the thing and removed it. So a tutorial path or an illustration is a skip with a reason, not a false alarm.
What it says on this repo today:
fetch-depth: 0is not optional, and the action refuses without it. Measured onpallets/click: a full clone reports1 brokenand exits 1, while the same repository at--depth 1reportsNothing contradictedand exits 0. Sinceactions/checkoutgives depth 1 by default, the quiet version of this check is a permanently green gate that judged nothing.