Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vectorStore experimental setting usage #718

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Remove vectorStore experimental setting usage #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d393172
Remove manual enabling
Strift Jan 30, 2025
1c9e8de
Remove unused import
Strift Jan 30, 2025
3d0e56f
Update default embedder expectations
Strift Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/Endpoints/DocumentsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,8 +680,6 @@ public function testGetDocumentsWithoutFilterCorrectFieldsFormat(): void

public function testGetDocumentsWithVector(): void
{
$http = new Client($this->host, getenv('MEILISEARCH_API_KEY'));
$http->patch('/experimental-features', ['vectorStore' => true]);
$index = $this->createEmptyIndex($this->safeIndexName('movies'));

$promise = $index->updateEmbedders(['manual' => ['source' => 'userProvided', 'dimensions' => 3]]);
Expand Down
2 changes: 0 additions & 2 deletions tests/Endpoints/SearchTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,8 +707,6 @@ public function testBasicSearchWithFacetsOptionAndMultipleFacets(): void

public function testVectorSearch(): void
{
$http = new Client($this->host, getenv('MEILISEARCH_API_KEY'));
$http->patch('/experimental-features', ['vectorStore' => true]);
$index = $this->createEmptyIndex($this->safeIndexName());

$promise = $index->updateEmbedders(['manual' => ['source' => 'userProvided', 'dimensions' => 3]]);
Expand Down
5 changes: 1 addition & 4 deletions tests/Settings/EmbeddersTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,17 @@
namespace Tests\Settings;

use Meilisearch\Endpoints\Indexes;
use Meilisearch\Http\Client;
use Tests\TestCase;

final class EmbeddersTest extends TestCase
{
private Indexes $index;

private const DEFAULT_EMBEDDER = null;
private const DEFAULT_EMBEDDER = [];

protected function setUp(): void
{
parent::setUp();
$http = new Client($this->host, getenv('MEILISEARCH_API_KEY'));
$http->patch('/experimental-features', ['vectorStore' => true]);
$this->index = $this->createEmptyIndex($this->safeIndexName());
}

Expand Down
20 changes: 0 additions & 20 deletions tests/Settings/SettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,24 +196,4 @@ public function testResetSettings(): void
self::assertSame(self::DEFAULT_FACET_SEARCH, $settings['facetSearch']);
self::assertSame(self::DEFAULT_PREFIX_SEARCH, $settings['prefixSearch']);
}

// Here the test to prevent https://github.com/meilisearch/meilisearch-php/issues/204.
// Rollback this comment after meilisearch v1.6.0 final release.
// Related to: https://github.com/meilisearch/meilisearch/issues/4323
//
// public function testGetThenUpdateSettings(): void
// {
// $http = new \Meilisearch\Http\Client($this->host, getenv('MEILISEARCH_API_KEY'));
// $http->patch('/experimental-features', ['vectorStore' => false]);
// $index = $this->createEmptyIndex($this->safeIndexName());

// $resetPromise = $index->resetSettings();
// $this->assertIsValidPromise($resetPromise);
// $index->waitForTask($resetPromise['taskUid']);

// $settings = $index->getSettings();
// $promise = $index->updateSettings($settings);
// $this->assertIsValidPromise($promise);
// $index->waitForTask($promise['taskUid']);
// }
}