Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

あなた宛て #2495

Draft
wants to merge 4 commits into
base: mei-v11
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 81 additions & 0 deletions src/misc/explain.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
// https://github.com/zamarawka/typeorm-explain/blob/8b5e798d6775b4c30713ae96695e4dcc4755b8ba/src/index.ts

import { writeFile } from 'fs/promises';
import { resolve } from 'path';
import { getConnection, ObjectLiteral, QueryBuilder, Connection } from 'typeorm';

type PostgresExplainParameters = {
analyze?: boolean;
verbose?: boolean;
costs?: boolean;
buffers?: boolean;
timing?: boolean;
};

type FormatTypes = 'text' | 'xml' | 'json' | 'yaml';

type ExplainParameters = undefined | PostgresExplainParameters;

type ExplainBuilder = (
originalQuery: string,
explainParameters: ExplainParameters,
format: FormatTypes,
) => string;

const explains: { [key: string]: ExplainBuilder } = {
postgres(
originalQuery: string,
explainParameters: PostgresExplainParameters = {
analyze: false,
verbose: false,
buffers: false,
},
format: FormatTypes,
) {
const boolParameters = Object.entries(explainParameters)
.filter((argument): argument is [string, boolean] => typeof argument[1] === 'boolean')
.map(([key, value]) => `${key} ${value}`);

const explainParametersString = [...boolParameters, `FORMAT ${format.toUpperCase()}`]
.join(', ')
.toUpperCase();

return `EXPLAIN (${explainParametersString}) ${originalQuery}`;
},
};

export default async function explain<T extends ObjectLiteral>(
qb: QueryBuilder<T>,
explainParameters?: ExplainParameters,
format: FormatTypes = 'text',
connection: Connection = getConnection(),
) {
const { type } = connection.driver.options;
const [originalQuery, queryParameters] = qb.getQueryAndParameters();
const explainBuilder: ExplainBuilder = explains[type];

if (!explainBuilder) {
const driversList = Object.keys(explains).join(',');

throw new Error(
`typeorm-explain currently support limited db drivers (${driversList}). Feel free open PR to support your driver: ${type}`,
);
}

const query = explainBuilder(originalQuery, explainParameters, format);

return connection.query(query, queryParameters);
}

export async function explain2<T extends ObjectLiteral>(qb: QueryBuilder<T>, name: string) {
const dir = resolve(__dirname, '../../');
const queryFile = resolve(dir, `_query_${name}.txt`);
const explainFile = resolve(dir, `_explain_${name}.txt`);

const [q, p] = qb.getQueryAndParameters();
await writeFile(queryFile, `${q}\n\n${JSON.stringify(p, null, 2)}`);

const r = await explain(qb) as { 'QUERY PLAN': string }[];
const t = r.map(x => x['QUERY PLAN']).join('\n');
await writeFile(explainFile, t);
}
14 changes: 8 additions & 6 deletions src/server/api/endpoints/notes/mentions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@ import $ from 'cafy';
import { ID } from '../../../../misc/cafy-id';
import define from '../../define';
import read from '../../../../services/note/read';
import { Notes, Followings } from '../../../../models';
import { Notes, Followings, Notifications } from '../../../../models';
import { generateVisibilityQuery } from '../../common/generate-visibility-query';
import { generateMuteQuery } from '../../common/generate-mute-query';
import { makePaginationQuery } from '../../common/make-pagination-query';
import { Brackets } from 'typeorm';
import { generateBlockedUserQuery } from '../../common/generate-block-query';
import { explain2 } from '../../../../misc/explain';

export const meta = {
desc: {
Expand Down Expand Up @@ -60,10 +61,7 @@ export default define(meta, async (ps, user) => {
.where('following.followerId = :followerId', { followerId: user.id });

const query = makePaginationQuery(Notes.createQueryBuilder('note'), ps.sinceId, ps.untilId)
.andWhere(new Brackets(qb => { qb
.where(`'{"${user.id}"}' <@ note.mentions`)
.orWhere(`'{"${user.id}"}' <@ note.visibleUserIds`);
}))
.innerJoin(Notifications.metadata.targetName, 'notification', 'notification.noteId = note.id')
.innerJoinAndSelect('note.user', 'user')
.leftJoinAndSelect('user.avatar', 'avatar')
.leftJoinAndSelect('user.banner', 'banner')
Expand All @@ -74,7 +72,9 @@ export default define(meta, async (ps, user) => {
.leftJoinAndSelect('replyUser.banner', 'replyUserBanner')
.leftJoinAndSelect('renote.user', 'renoteUser')
.leftJoinAndSelect('renoteUser.avatar', 'renoteUserAvatar')
.leftJoinAndSelect('renoteUser.banner', 'renoteUserBanner');
.leftJoinAndSelect('renoteUser.banner', 'renoteUserBanner')
.andWhere('notification.notifieeId = :notificatin_notifieeId', { notificatin_notifieeId: user.id })
.andWhere('notification.type IN (:...notificatin_type)', { notificatin_type: ['reply', 'mention'] });

generateVisibilityQuery(query, user);
generateMuteQuery(query, user);
Expand All @@ -89,6 +89,8 @@ export default define(meta, async (ps, user) => {
query.setParameters(followingQuery.getParameters());
}

explain2(query, 'mentions');

const mentions = await query.take(ps.limit!).getMany();

for (const note of mentions) {
Expand Down