This repository was archived by the owner on May 30, 2023. It is now read-only.
feat: support target wasm-unknown-emscripten#100
Open
0neSe7en wants to merge 3 commits intomeh:masterfrom
Open
feat: support target wasm-unknown-emscripten#1000neSe7en wants to merge 3 commits intomeh:masterfrom
0neSe7en wants to merge 3 commits intomeh:masterfrom
Conversation
0neSe7en
changed the title
kornelski
suggested changes
Sep 7, 2021
| .parse_callbacks(Box::new(Callbacks)); | ||
|
|
||
| if is_wasm_emscripten { | ||
| let emsdk_path = PathBuf::from(env::var("EMSDK").unwrap()); |
Collaborator
There was a problem hiding this comment.
Is this guaranteed to be set?
At very least I'd prefer it to be .expect() with a message that explains what it should contain.
Author
There was a problem hiding this comment.
And may add document about target=wasm32-unknown-emscripten in README.md or somewhere else?
User need to install EMSDK and activate it, and compiling FFmpeg with Emscripten also not easy
|
|
||
| if is_wasm_emscripten { | ||
| let emsdk_path = PathBuf::from(env::var("EMSDK").unwrap()); | ||
| let emsdk_sysroot = emsdk_path.join("upstream/emscripten/cache/sysroot"); |
Collaborator
There was a problem hiding this comment.
/cache/ doesn't make it sound like a permanent directory.
Maybe check if the path exists and panic with an error that tells user how to create it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for compiling rust and FFmpeg to target
wasm-unknown-emscriptenwith prebuilt static library