Changed output from stderr to stdout if the checksum is ok. #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was running the tests on the master and they are failing too. So could it be the failing tests where not related to my PR? |
|
Right, it does look like something changed that makes the Mac tests fail, let me look into this... |
If something if fine, it should not (IMHO) be on stderr. This could cause false alarms to users where makeself is embedded into another installer. Signed-off-by: Jan Vermaete <[email protected]>
|
The tests are now passing again (completely unrelated). I guess I am OK with this change as long as the quiet flag is honored for use cases when the output may need to be parsed. |
megastep
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If something if fine, it should not (IMHO) be on stderr. This could cause false alarms to users where makeself is embedded into another installer.