Add a pre-extract script (issue #242) #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoberezhniy
changed the title
|
Interesting contribution thanks! Your tests seem to fail at least on macOS but if you manage to make it pass on all platforms I'd be inclined to approve it. |
|
@megastep Thanks for the review. I pushed a commit that should resolve the mktemp issues and also when testing on an alpine container I hit an issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description #242:
Being able to specify a pre-extraction script can significantly improve user experience when dealing with large archives by doing the following before decompressing and failing fast.
The pre-extraction script can be written in any programming language as long as it provides a shebang. It receives the same cli arguments as the main script. It will be executed in the target dir, it allows asking for user input and passing it to the main script as shown in
testPreextractEnvPassingtest.The pre-extraction script is stored in the header as a variable. When it is used - a file with the stored contents is created and run.