Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Notification Center in OS X Mavericks. #76

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Added support for Notification Center in OS X Mavericks. #76

wants to merge 9 commits into from

Conversation

cordevx2
Copy link

Added a Notifcation Center alert when uploading individual or multiple
assets to Shopify. Users must install the gem 'terminal-notifier'.

Also, this change requires TextMate 2 preview in order for the icon to
show up correctly in Notification Center.

Added a Notifcation Center alert when uploading individual or multiple
assets to Shopify. Users must install the gem 'terminal-notifier'.
Also, this change requires TextMate 2 preview in order for the icon to
show up correctly in Notification Center.
@meeech
Copy link
Owner

meeech commented Nov 12, 2013

Hey Dale,
thanks. thats great, but i'm unlikely to merge this in as it now stands.
It would need to check if gem is installed and so forth. Anyone without this gem, would just get errors.
Not clear from gem what its behaviour would be in pre-10.8 circumstance.
Personally, i'd suggest it being a config option you could enable (not something i have time to do).

In anycase, its good you've put this out there - anyone searching for that functionality will now find this fork as well, so thats good.

@cordevx2
Copy link
Author

Great, thanks for the feedback. Much appreciated.

Dale

Dale Tournemille and others added 8 commits November 12, 2013 11:32
e-switcher-support'

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
This rolls back to commit ced2a27.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants