Fix: Logout not working on dashboard#121
Open
teenananana wants to merge 1 commit intomeabhisingh:masterfrom
Open
Fix: Logout not working on dashboard#121teenananana wants to merge 1 commit intomeabhisingh:masterfrom
teenananana wants to merge 1 commit intomeabhisingh:masterfrom
Conversation
Author
|
hi, I have these changes Added axios.defaults.withCredentials = true in App.js and included navigate('/login') after dispatch(logout()). kindly review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logout button on the Dashboard was not redirecting users to the login page after logging out, causing the session to appear active until a manual refresh. This issue occurred because Axios was not configured to send credentials with requests, and the logout handler lacked a navigation redirect. The fix involved adding axios.defaults.withCredentials = true in App.js to ensure proper session handling and including navigate('/login') after the logout() dispatch in the logout function. After these changes, the logout now clears the session correctly and redirects users to the login page as expected.