Skip to content

Conversation

@A-CGray
Copy link
Member

@A-CGray A-CGray commented Aug 7, 2023

Purpose

#89 Added new capabilities, so we should make a new minor release

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner August 7, 2023 20:12
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #91 (fca7b8d) into main (5688faa) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   35.42%   35.42%           
=======================================
  Files          26       26           
  Lines        2586     2586           
=======================================
  Hits          916      916           
  Misses       1670     1670           
Files Changed Coverage Δ
baseclasses/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anilyil anilyil merged commit d447863 into main Aug 7, 2023
@A-CGray A-CGray deleted the A-CGray-patch-1 branch August 7, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants